fix: build packages before changeset publish#14
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthroughリリース手順を変更するため、Changesetファイルを追加し、ワークスペース・ビルド用スクリプトをpackage.jsonに追加、 Changes
Sequence Diagram(s)(該当なし) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
詩
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9b21a1c to
fadaaac
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildスクリプトを追加(pnpm -r run buildで全パッケージをビルド)releaseスクリプトをビルド前実行に変更(pnpm run build && changeset publish)changeset publish実行前にdistが生成されず、npm に publish されても空になっていた問題を修正。Summary by CodeRabbit
Chores