Skip to content

refactor(next-typed-href): move type aliases into defineTypedHrefWithNuqs closure#47

Merged
amotarao merged 1 commit intomainfrom
amon/pc-63-definetypedhrefwithnuqs-move-types
Apr 21, 2026
Merged

refactor(next-typed-href): move type aliases into defineTypedHrefWithNuqs closure#47
amotarao merged 1 commit intomainfrom
amon/pc-63-definetypedhrefwithnuqs-move-types

Conversation

@amotarao
Copy link
Copy Markdown
Member

@amotarao amotarao commented Apr 21, 2026

概要

fix https://linear.app/plainbrew/issue/PC-63

packages/next-typed-href/src/nuqs.ts のトップレベル型エイリアスを defineTypedHrefWithNuqs のクロージャ内に移動。

  • RouteHasParams → 外側クロージャ(Routes/RouteParamsMap をキャプチャ)
  • SearchParamsFor / PathOptionsFor → 内側クロージャ(NuqsMap もキャプチャ)

index.tsdefineTypedHref と同じ構造に統一し、各型の型パラメータを削減。

参考

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9271bdca-699a-4d16-b175-ec4e4581df18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amon/pc-63-definetypedhrefwithnuqs-move-types

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotarao amotarao requested review from akameco and iromonek39 April 21, 2026 02:56
@akameco akameco removed the request for review from iromonek39 April 21, 2026 03:24
Base automatically changed from amon/pc-62-definetypedhrefwithnuqs-withdefault to main April 21, 2026 03:26
@amotarao amotarao merged commit 6bcde8d into main Apr 21, 2026
2 checks passed
@amotarao amotarao deleted the amon/pc-63-definetypedhrefwithnuqs-move-types branch April 21, 2026 03:26
@github-actions github-actions Bot mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants