Skip to content

chore: migrate build tool from tsup to tsdown#52

Merged
amotarao merged 2 commits intomainfrom
amon/pc-65-migrate-tsup-to-tsdown
Apr 28, 2026
Merged

chore: migrate build tool from tsup to tsdown#52
amotarao merged 2 commits intomainfrom
amon/pc-65-migrate-tsup-to-tsdown

Conversation

@amotarao
Copy link
Copy Markdown
Member

@amotarao amotarao commented Apr 22, 2026

Summary

fix https://linear.app/plainbrew/issue/PC-65

  • ビルドツールを tsup から tsdown に移行
  • tsup は現在メンテナンスされていないため(参照
  • 両パッケージの tsup.config.tstsdown.config.ts にリネーム
  • package.jsonscriptsdevDependencies を更新
  • "type": "module" を各 package.json に追加(ESM 専用パッケージのため)

tsup との出力の差異

動作・型は同一です。

項目 tsup tsdown
.mjs のインデント スペース タブ
.mjs へのソース領域コメント なし //# region src/... が追加
.mjs への JSDoc コメント 含まれない 含まれる
.d.mts のインデント 4 スペース 2 スペース
.d.mts の末尾改行 あり なし
exporttype キーワード あり(export { type Foo } なし(export { Foo }

Test plan

  • pnpm --filter "@plainbrew/next-typed-href" build 成功
  • pnpm --filter "@plainbrew/vercel-basic-auth" build 成功

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Walkthrough

2つのパッケージ(next-typed-hrefvercel-basic-auth)でビルドツールを tsup から tsdown に移行し、各 package.json"type": "module" を追加、関連する tsdown.config.tsdefineConfig のインポート元を更新、README と changeset を追記しました。

Changes

Cohort / File(s) Summary
Build tool & package metadata
packages/next-typed-href/package.json, packages/vercel-basic-auth/package.json
"type": "module" を追加。devbuild スクリプトで tsuptsdown に置換。devDependencies から tsup を削除し tsdown を追加。
Config import updates
packages/next-typed-href/tsdown.config.ts, packages/vercel-basic-auth/tsdown.config.ts
defineConfig のインポート元を tsup から tsdown に変更。設定オブジェクト自体は変更なし。
Documentation
README.md
プロジェクトのビルドツール欄を追加し、tsuptsdown の出力差分(.mjs/.d.mts の書式、JSDoc/SOURCE REGIONの有無、export表現の差)を説明を追記。
Release notes
.changeset/migrate-tsup-to-tsdown.md
@plainbrew/next-typed-href@plainbrew/vercel-basic-auth のパッチリリースを宣言する changeset を追加(メッセージ: migrate build tool from tsup to tsdown)。

Sequence Diagram(s)

(該当なし)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • akameco
  • iromonek39

Poem

🐰 朝露のコード畑で、ぽんぽん跳ねる、
tsup を残して tsdown の小径へ、
package.json に風が立ち、
ビルドは軽やかに踊るよ、
新しい一歩、ぴょん!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR タイトル「chore: migrate build tool from tsup to tsdown」は、変更セットの主要な内容(tsup から tsdown への移行)を正確かつ明確に要約している。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amon/pc-65-migrate-tsup-to-tsdown

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotarao amotarao force-pushed the amon/pc-65-migrate-tsup-to-tsdown branch from d06652f to 0510df2 Compare April 22, 2026 15:45
@amotarao amotarao force-pushed the amon/pc-65-migrate-tsup-to-tsdown branch from f99fa17 to 59c279f Compare April 22, 2026 15:52
@amotarao amotarao requested review from akameco and iromonek39 April 22, 2026 15:53
@akameco akameco removed the request for review from iromonek39 April 28, 2026 00:49
Copy link
Copy Markdown

@akameco akameco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build OK.LGTM!

@amotarao amotarao merged commit 9fe6b02 into main Apr 28, 2026
3 checks passed
@amotarao amotarao deleted the amon/pc-65-migrate-tsup-to-tsdown branch April 28, 2026 00:59
@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants