chore: migrate build tool from tsup to tsdown#52
Merged
Conversation
Walkthrough2つのパッケージ( Changes
Sequence Diagram(s)(該当なし) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
d06652f to
0510df2
Compare
f99fa17 to
59c279f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix https://linear.app/plainbrew/issue/PC-65
tsupからtsdownに移行tsup.config.ts→tsdown.config.tsにリネームpackage.jsonのscriptsとdevDependenciesを更新"type": "module"を各package.jsonに追加(ESM 専用パッケージのため)tsup との出力の差異
動作・型は同一です。
.mjsのインデント.mjsへのソース領域コメント//# region src/...が追加.mjsへの JSDoc コメント.d.mtsのインデント.d.mtsの末尾改行exportのtypeキーワードexport { type Foo })export { Foo })Test plan
pnpm --filter "@plainbrew/next-typed-href" build成功pnpm --filter "@plainbrew/vercel-basic-auth" build成功