add consensus UI by dreacot · Pull Request #729 · planetdecred/godcr

dreacot · 2021-12-24T16:48:18Z

Requires planetdecred/dcrlibwallet#216

resolves #655
Fix #776

ui/load/vsp.go

ui/page/governance/agenda_vote_modal.go

ui/load/load.go

ui/page/components/consensus_list.go

ui/page/governance/proposals_page.go

Sirmorrison

* The vote/change vote button text is wrapped and not properly aligned. * Every word on the agenda subject/title should be capitalized.

The vote button should not be visible for finished vote.
Also, use a shadow widget for the agendas when they are hovered so the background is not hidden when hovered.
Something similar was done for the more page and the security page.

The navigation does not conform to the mock up.

mock up

ui/page/governance/agenda_vote_modal.go

ui/page/components/consensus_list.go

dreacot · 2022-02-21T19:29:21Z

the data returned from the blockchain doesn't come capitalised, and is displayed as is in decredition as well
why shouldn't the vote button be visible for finished votes?, that's the mockup style, visible but grayed out
the mockup wasn't done with proper research which is why the wallet dropdown is missing from it
I used the existing search bar as used on the proposals page, designing a new search bar is outside the scope of this work, if someone designs it, i'd gladly update the proposals and consensus pages with it, moreover, the search bar would be commented out as we aren't releasing with the search functionality

itswisdomagain

First pass. General feedback from testing.

Do you really need to have live tickets to be able to set voting preferences? Remember that locally saved preferences are applied to new tickets, so I suppose it is fine to let users save preferences locally only, if there's no ticket purchased yet.
Governance page -> Proposals tab shows one prop in discussion. Decrediton has none.
Governance page -> Consensus tab shows 4 in progress agendas, Decrediton has none in progress. Also, the link to the voting dashboard for testnet should be https://voting.decred.org/testnet.

Lastly, and this may be something for after this PR is merged. The green tick icon for finished agendas is meant to show that the agenda voting passed. Decrediton uses dcrdata API to get this info.

itswisdomagain

Haven't looked too deep, but here's for now.

ui/page/components/components.go

ui/page/components/consensus_list.go

dreacot · 2022-03-02T16:08:13Z

"Governance page -> Proposals tab shows one prop in discussion. Decrediton has none.", can't replicate this, there are no proposals in discussion on godcr

dreacot · 2022-03-02T20:33:52Z

"Governance page -> Consensus tab shows 4 in progress agendas,", looking into this

itswisdomagain · 2022-03-04T13:12:18Z

"Governance page -> Proposals tab shows one prop in discussion. Decrediton has none.", can't replicate this, there are no proposals in discussion on godcr

update with dcrlibwallet

- use dcrlibwallet agenda status constants

- document StakeToTransactionItems() - update dcrlibwallet dep - change vote text on agenda button"

cleanup code

- cleanup code

- change "Voting wallet" to selected "wallet" - use an array instead of a map for the vote choices

…rence

itswisdomagain

Would have left review comments but did some tinkering while testing and want to share the thoughts in this commit instead: itswisdomagain@4d1dfeb.

That should resolve the slowness issue @Sirmorrison experienced, must have been due to the network call being made on the UI thread.

Also bump the dcrlibwallet mod version to master once the related dcrlibwallet PR is merged.

code cleanup

Sirmorrison · 2022-03-15T20:28:51Z

LGTM @itswisdomagain kindly review before we merge.

itswisdomagain

I changed the status of one of the agendas to upcoming in order to test how updating the voting preference works, noticed this slight issue (may not even be an issue).

When my wallet launched, it showed I had 2 immature tickets, although they had actually voted but my wallet isn't synced yet, so it doesn't know. When I tried to update voting preferences for the agenda I modified to upcoming, it gave an error about ticket already voted. The issue resolved itself when the wallet finished syncing.

I'm currently unable to buy another ticket to test with, to ensure the vsp associated with the ticket gets the correct voting preference set. But this should be good to merge after the go mod tidy stuff below. There'd be more testing to be done after this hits master, such as ensuring that tickets purchased before and after setting the vote preference gets the correct preference set with the vsp.

go.mod

* add tab to governance page to switch between proposal and consensus pages * implement consensus page * add consensus listeners - implement vote for consensus - cleanup code * remove notification listeners implementations * remove syncing section * reload page after voting * add dcrlibwallet PR requirement * fix bug where agenda page wasn't reloaded after voting * add ticket dropdown * fix bug where ticket list wasn't gotten per wallet, but gotten for all wallets * fix error where pubkey was 0 length - handle getting agenda status from dcrlibwallet * fix bug where the vote modal voting options wasn't - updating based on the selected wallet * remove validation check for if a ticket is selected while trying to vote on agendas * use proper background color for agenda status * update UI for voting modal * adjust governance page tab UI * update dcrlibwallet implementation * move vsp selector to components file - delete vsp.go file - cleanup code * code cleanup * simplified code structure - remove unwanted comments - cleanup code * add hover effect to icon on consensus page * fix vote button wrapping * remove redundant boolean call * change H6 to Label * add shadow to agenda items * add open in browser section * Rearrange widget position, label font size and code clean up * implement shadow on clickable_list widget - remove redundant lines of codes - fix excess padding and general code clean up * move consensus and proposal handle properties to individual pages. - clean up and optimize code * some modifications were made to dcrlibwallet on how some consensus -methods were called, the necessary changes were implemented in this commit; - mainly changing the consensus methods from multiwallet methods to wallet methods * show modal when the info icons on the governance page is clicked - make the voting dashboard redirect to the correct URL - fix crash that occurred when navigating from the governance page * update dcrlibwallet dep * update dcrlibwallet dep * add testnet host for the voting dashboard * remove vsp selector from the agenda vote modal update with dcrlibwallet * rename AgendaList to AgendaItemWidget - use dcrlibwallet agenda status constants * move WalletLiveTickets() method to dcrlibwallet - document StakeToTransactionItems() - update dcrlibwallet dep - change vote text on agenda button" * fix update preference button width * fix bug where voting options were being re-arranged cleanup code * update agenda status call * don't store cl.shadow property * give variables in agenda modal proper names - change "Voting wallet" to selected "wallet" - use an array instead of a map for the vote choices * use call back to reload agenda list after updating the voting preference * move stakeToTransactionItems back to staking utils page * fix delay while opening consensus tab * bump dcrlibwallet dep * allow users vote for upcoming agendas Co-authored-by: sirmorrison <edonomorrison@gmail.com>

dreacot force-pushed the consensus_ui branch 3 times, most recently from 4927804 to 69f0f9f Compare January 19, 2022 19:21

dreacot force-pushed the consensus_ui branch 3 times, most recently from d43b8ae to fbd04ba Compare February 7, 2022 19:36

dreacot marked this pull request as ready for review February 7, 2022 19:41

dreacot changed the title ~~W.I.P add consensus UI~~ add consensus UI Feb 7, 2022

dreacot force-pushed the consensus_ui branch from fbd04ba to 50867e6 Compare February 9, 2022 00:05

Sirmorrison suggested changes Feb 9, 2022

View reviewed changes

ui/load/vsp.go Outdated Show resolved Hide resolved

ui/page/governance/agenda_vote_modal.go Outdated Show resolved Hide resolved

dreacot force-pushed the consensus_ui branch from 50867e6 to 7cd7b46 Compare February 9, 2022 08:45

Sirmorrison force-pushed the consensus_ui branch from 7cd7b46 to ba02896 Compare February 9, 2022 09:58

dreacot force-pushed the consensus_ui branch 2 times, most recently from e168d4d to 95c9691 Compare February 9, 2022 12:33

Sirmorrison suggested changes Feb 10, 2022

View reviewed changes

Sirmorrison suggested changes Feb 13, 2022

View reviewed changes

dreacot force-pushed the consensus_ui branch 2 times, most recently from ffc22cf to 04ef2d9 Compare February 23, 2022 18:49

Sirmorrison force-pushed the consensus_ui branch 3 times, most recently from 56299ae to caf49ae Compare February 26, 2022 22:28

dreacot force-pushed the consensus_ui branch 2 times, most recently from 232bb01 to 2da1908 Compare February 28, 2022 13:53

itswisdomagain suggested changes Mar 1, 2022

View reviewed changes

dreacot force-pushed the consensus_ui branch from 9e4f748 to b8b3e67 Compare March 2, 2022 20:20

dreacot added 12 commits March 15, 2022 11:45

update dcrlibwallet dep

3aeb0c4

add testnest host for the voting dashboard

cbf4eb7

remove vsp selector from the agenda vote modal

e682132

update with dcrlibwallet

- rename AgendaList to AgendaItemWidget

b0c563a

- use dcrlibwallet agenda status constants

update dcrlibwallet dep

9cfa6e4

- move WalletLiveTickets() method to dcrlibwallet

3902242

- document StakeToTransactionItems() - update dcrlibwallet dep - change vote text on agenda button"

fix update preference button width

d579699

fix bug where voting options were being re-arranged

c69a6e1

cleanup code

update agenda status call

6ff4026

- don't store cl.shadow property

09c26a3

- cleanup code

- give variables in agenda modal proper names

5d78627

- change "Voting wallet" to selected "wallet" - use an array instead of a map for the vote choices

- use call back to reload agenda list after updating the voting prefe…

057540b

…rence

dreacot force-pushed the consensus_ui branch from b8875d5 to 0070b87 Compare March 15, 2022 11:06

move stakeToTransactionItems back to staking utils page

dcff6e7

dreacot force-pushed the consensus_ui branch from 0070b87 to dcff6e7 Compare March 15, 2022 11:09

itswisdomagain suggested changes Mar 15, 2022

View reviewed changes

dreacot added 2 commits March 15, 2022 17:30

fix delay while opening consensus tab

9402828

code cleanup

bump dcrlibwallet dep

07ac0b3

allow users vote for upcoming agendas

c5f175b

itswisdomagain previously approved these changes Mar 17, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

dreacot dismissed itswisdomagain’s stale review via 2eaafc8 March 17, 2022 10:36

cleanup code

61d6642

dreacot force-pushed the consensus_ui branch from 2eaafc8 to 61d6642 Compare March 17, 2022 10:43

itswisdomagain approved these changes Mar 18, 2022

View reviewed changes

Sirmorrison approved these changes Mar 18, 2022

View reviewed changes

Sirmorrison merged commit bc9a209 into planetdecred:master Mar 18, 2022

This was referenced Mar 23, 2022

Add consensus voting capability planetdecred/dcrios#889

Open

Add consensus voting capability planetdecred/dcrandroid#619

Open

Conversation

dreacot commented Dec 24, 2021 • edited by Sirmorrison Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sirmorrison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dreacot commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itswisdomagain left a comment

Choose a reason for hiding this comment

Uh oh!

itswisdomagain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dreacot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dreacot commented Mar 2, 2022

Uh oh!

itswisdomagain commented Mar 4, 2022

Uh oh!

itswisdomagain left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sirmorrison commented Mar 15, 2022

Uh oh!

itswisdomagain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dreacot commented Dec 24, 2021 •

edited by Sirmorrison

Loading

dreacot commented Feb 21, 2022 •

edited

Loading

dreacot commented Mar 2, 2022 •

edited

Loading

itswisdomagain left a comment •

edited

Loading