Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 12, 2025

Related Issue(s):

Addresses feedback from #1201 (comment #1201 (comment))

Proposed Changes:

For inclusion in changelog (if applicable):

  1. N/A - internal refactoring only

Not intended for changelog:

  1. Import and use DEFAULT_DESTINATION_REF constant from planet.clients.destinations in planet/order_request.py instead of hardcoding 'pl:destinations/default'

Diff of User Interface

Old behavior:

# planet/order_request.py hardcoded the destination reference
def default_destination(path_prefix: Optional[str] = None) -> dict:
    parameters: Dict[str, Any] = {'ref': 'pl:destinations/default'}
    ...

New behavior:

# planet/order_request.py now uses the constant for consistency
from .clients.destinations import DEFAULT_DESTINATION_REF

def default_destination(path_prefix: Optional[str] = None) -> dict:
    parameters: Dict[str, Any] = {'ref': DEFAULT_DESTINATION_REF}
    ...

Both planet/order_request.py and planet/subscription_request.py now use the same constant, establishing single source of truth.

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:
@asonnenschein


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on default destination support implementation Use DEFAULT_DESTINATION_REF constant in order_request.py Nov 12, 2025
Copilot AI requested a review from asonnenschein November 12, 2025 16:56
Copilot finished work on behalf of asonnenschein November 12, 2025 16:56
@asonnenschein asonnenschein marked this pull request as ready for review November 12, 2025 16:59
@asonnenschein asonnenschein merged commit 2482597 into adrian/default-destinations Nov 12, 2025
asonnenschein added a commit that referenced this pull request Nov 17, 2025
* default destinations sdk and cli support

* add tests

* yapf

* fix type issues

* fix parameter name

* update cli docs

* Update planet/subscription_request.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Use DEFAULT_DESTINATION_REF constant in order_request.py (#1202)

* Initial plan

* Use DEFAULT_DESTINATION_REF constant in order_request.py

Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants