Skip to content

add 'host' to password response#142

Merged
iheanyi merged 2 commits intoplanetscale:mainfrom
kevinschoonover:kschoon/password-host
Oct 24, 2022
Merged

add 'host' to password response#142
iheanyi merged 2 commits intoplanetscale:mainfrom
kevinschoonover:kschoon/password-host

Conversation

@kevinschoonover
Copy link
Copy Markdown
Contributor

@kevinschoonover kevinschoonover commented Oct 23, 2022

Parse the 'access_host_url' from create password requests which contains the planetscale host to connect to

{"type":"BranchPassword","access_host_url":"us-west.connect.psdb.cloud"}

closes #115 since the username can be gotten through Username

@kevinschoonover kevinschoonover requested a review from a team as a code owner October 23, 2022 19:08
Copy link
Copy Markdown
Contributor

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @kevinschoonover. It's appreciated!

Comment thread planetscale/passwords.go Outdated
@iheanyi iheanyi merged commit b053b87 into planetscale:main Oct 24, 2022
@kevinschoonover kevinschoonover deleted the kschoon/password-host branch October 26, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add host and username into DatabaseBranchPassword

2 participants