Merged
Conversation
victorskl
reviewed
Jun 17, 2019
Member
victorskl
left a comment
There was a problem hiding this comment.
@rakeshchoyal92 Please create docker directory at root; having the following structure:
tree -L 2 backend/
backend/
├── docker
│ ├── release
│ └── snapshot
└── server
├── Procfile
├── ...
And have Dockerfile put into respective release and snapshot folder for e.g. production releases and development releases.
Also; please move server/README.md to project root directory and incorporate Django portion from frontend repo README.
ef80b03 to
638b239
Compare
638b239 to
10dbcab
Compare
Collaborator
Author
|
@victorskl And moved README to the root directory. |
victorskl
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.