Skip to content

[2] Dockerised the application#3

Merged
rakeshchoyal92 merged 1 commit intodevelopfrom
dockerise_application
Jun 19, 2019
Merged

[2] Dockerised the application#3
rakeshchoyal92 merged 1 commit intodevelopfrom
dockerise_application

Conversation

@rakeshchoyal92
Copy link
Copy Markdown
Collaborator

No description provided.

@rakeshchoyal92 rakeshchoyal92 requested a review from victorskl June 17, 2019 01:40
Copy link
Copy Markdown
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakeshchoyal92 Please create docker directory at root; having the following structure:

tree -L 2 backend/
backend/
├── docker
│   ├── release
│   └── snapshot
└── server
    ├── Procfile
    ├── ...

And have Dockerfile put into respective release and snapshot folder for e.g. production releases and development releases.

Also; please move server/README.md to project root directory and incorporate Django portion from frontend repo README.

@rakeshchoyal92 rakeshchoyal92 force-pushed the dockerise_application branch from ef80b03 to 638b239 Compare June 18, 2019 01:22
@rakeshchoyal92 rakeshchoyal92 force-pushed the dockerise_application branch from 638b239 to 10dbcab Compare June 18, 2019 01:25
@rakeshchoyal92
Copy link
Copy Markdown
Collaborator Author

@victorskl
Created Docker directory at root with the following structure

├── docker
│   ├── release
│   └── snapshot
└── server
    ├── Procfile
    ├── ... 

And moved README to the root directory.

@rakeshchoyal92 rakeshchoyal92 merged commit 7b27d4f into develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants