Skip to content

Feature/43 unit test#45

Merged
nirlipo merged 5 commits intodevelopfrom
feature/43-unit-test
Oct 29, 2020
Merged

Feature/43 unit test#45
nirlipo merged 5 commits intodevelopfrom
feature/43-unit-test

Conversation

@JamieYuu
Copy link
Copy Markdown
Member

@JamieYuu JamieYuu commented Oct 16, 2020

Added unit test feature to the project

@JamieYuu
[43] Unit test framework
0baf443 
* Applied python unit test module to the project
* Created test case for testing domain_parser, problem_parser, predicates_generator, solver and the whole process.

Resolves #43
@JamieYuu
[43] Unit test framework
b85239d 
* Add README file

Resolves #43
@JamieYuu JamieYuu requested a review from nirlipo October 16, 2020 01:10
nirlipo
nirlipo requested changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nirlipo nirlipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Besides the comments in the files, I have 2 more questions:

  • Should we move the test folder out of app?
  • Can you group the input files into different folders?

Thanks!

server/app/unit_test/README.md Outdated
Ran 8 tests in 1.967s

OK
```
Copy link
Copy Markdown
Contributor

@nirlipo nirlipo Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it runs, can it give you some output messages of the tests it passed?

Why didn't we use django.tests?

@JamieYuu
[43] Unit test framework
f40d52b 
* Move the unit test folder out of the app folder
* Created a folder to takes all the expected output files for comparing with the output
* Added failure message to indicate the errors
* Added comments for the test cases

Resolves #43
@JamieYuu
Copy link
Copy Markdown
Member Author

JamieYuu commented Oct 26, 2020

Hi @nirlipo , sorry for the late response, I was focusing on the planning-as-service project and forgot to check the messages here. I've made a few changes to the unit test branch according to your comments.

For the django.test, we found the document says

Django’s unit tests use a Python standard library module: unittest

From a functional point of view, using Django.test is the same as using the Python unittest module directly. So we think just using the Python unittest module would be more light and easy to use, and won't cause any potential conflict with the existing features.
We are looking forward to your reply, thank you for your time!

nirlipo
nirlipo requested changes Oct 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nirlipo nirlipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Please update the output in the Readme and we are ready to merge!

@JamieYuu
[43] Unit test framework
4bba895 
* Added error message and exception message parts in the README.md

Resolves #43
nirlipo
nirlipo approved these changes Oct 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@nirlipo nirlipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nirlipo
Copy link
Copy Markdown
Contributor

nirlipo commented Oct 29, 2020

Please let me know how to include this on the travis pipeline!

@nirlipo nirlipo merged commit e20f697 into develop Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirlipo nirlipo nirlipo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamieYuu @nirlipo