fixed issue #224 - toggle_bool_column for modulized or decorated models#237
Merged
ldlsegovia merged 1 commit intoplatanus:masterfrom Mar 23, 2019
qdegraeve:fix-toggle-boolean-column
Merged
fixed issue #224 - toggle_bool_column for modulized or decorated models#237ldlsegovia merged 1 commit intoplatanus:masterfrom qdegraeve:fix-toggle-boolean-column
ldlsegovia merged 1 commit intoplatanus:masterfrom
qdegraeve:fix-toggle-boolean-column
Conversation
Contributor
|
Hi @qdegraeve , thank you for notice and for fixing this error. In order to merge your PR could you please fix the conflicts doing a rebase with master? after that we will merge your contribution. |
monkeyci
reviewed
Mar 14, 2019
monkeyci
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableName has the wrong namespace - should be Naming .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming .rubocop.yml: Style/ConstantName has the wrong namespace - should be Naming .rubocop.yml: Style/FlipFlop has the wrong namespace - should be Lint .rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When models registered in activeadmin are decorated or contain a module, the
class_namemethod in thecustom_builder.rbwas not working .