Skip to content

Run kind e2e test#37

Merged
cnvergence merged 2 commits intomainfrom
make-e2e-test
Oct 2, 2025
Merged

Run kind e2e test#37
cnvergence merged 2 commits intomainfrom
make-e2e-test

Conversation

@cnvergence
Copy link
Copy Markdown
Collaborator

@cnvergence cnvergence commented Sep 30, 2025

Summary by CodeRabbit

  • Tests

    • Enabled CI end-to-end test workflow and added a make target to run e2e tests locally.
    • Improved test stability with more robust readiness waits and consistent resource naming.
    • Reduced flakiness by removing strict ownership assertions.
    • Tests can now select the operator image via environment variables; cluster setup can be conditional.
  • Chores

    • Made tooling commands configurable (kind/helm/kubectl) and updated deployment image reference in manifest.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 30, 2025

Walkthrough

Enables e2e workflow in GitHub Actions, updates Makefile targets and flags for e2e and Helm/kubectl usage, changes controller image in Kustomize, and refactors tests to adjust image resolution, resource names, readiness waits, and optional cluster setup.

Changes

Cohort / File(s) Summary of Changes
CI workflow
.github/workflows/e2e.yaml
Uncomments and activates the e2e job step; adds a single active step “Run e2e tests” that executes make kind-test-e2e; fixes indentation and command alignment.
Make targets / build tooling
Makefile
Introduces KIND and HELM variables; routes various targets to use $(KIND)/$(HELM) instead of hardcoded commands; ensures IMG/SETUP_CLUSTER are passed to e2e test targets; adds kind-test-e2e target; updates chart/helm, kind, and docker-related commands.
Kustomize image
config/manager/kustomization.yaml
Updates controller image reference: sets newName to ghcr.io/platform-mesh/example-httpbin-operator and newTag to 5c05354-dirty.
Test constants
test/common.go
Renames exported constant OperatorImageDefaultOperatorImage (same value "controller:dev").
Test harness / main
test/main_test.go
setupOperator signature updated to accept operatorImage string; TestMain resolves operator image from IMG (fallback to DefaultOperatorImage), conditionally runs cluster setup via SETUP_CLUSTER, and passes resolved image into setup and image load steps.
Test utilities
test/test_utils.go
Adjusts deployment name used in readiness waits (from OperatorName + "-controller-manager" to OperatorName); changes service wait/name to httpbin-<Name>.
E2E deployment test
test/deployment_test.go
Replaces previous Deployment/Service readiness/ownership checks with explicit Get-and-wait loops; removes OwnerReference assertions; updates resource names to httpbin-test-httpbin-deployment and aligns deletion/wait names accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between c56725a and bd1f29b.

📒 Files selected for processing (1)
  • Makefile (5 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@cnvergence cnvergence linked an issue Sep 30, 2025 that may be closed by this pull request
Comment thread Makefile Outdated
Comment thread Makefile
Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
Copy link
Copy Markdown
Contributor

@mirzakopic mirzakopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm

@cnvergence cnvergence merged commit 328000c into main Oct 2, 2025
11 checks passed
@cnvergence cnvergence deleted the make-e2e-test branch October 2, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup e2e test scenario in the CI

2 participants