Skip to content

Add ocm to example-httpbin-operator#38

Merged
cnvergence merged 6 commits intomainfrom
add-ocm
Oct 3, 2025
Merged

Add ocm to example-httpbin-operator#38
cnvergence merged 6 commits intomainfrom
add-ocm

Conversation

@cnvergence
Copy link
Copy Markdown
Collaborator

@cnvergence cnvergence commented Oct 1, 2025

Summary by CodeRabbit

  • Chores
    • Added a reusable CI workflow to package and publish OCM components; triggers on ocm-* tags, main branch updates, PRs targeting main, and can be invoked by other workflows.
    • Added an OCM component configuration for the example HTTPBin Operator, declaring its Helm chart, container image, and component dependencies.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 1, 2025

Walkthrough

Introduces a new GitHub Actions workflow for OCM releases and adds an OCM component constructor YAML defining the example-httpbin-operator component with Helm chart and image resources.

Changes

Cohort / File(s) Summary
CI workflow: OCM release
`.github/workflows/job-ocm.yaml`
Adds an "OCM" workflow triggered on tag pushes matching ocm-* and pushes to main; delegates to a reusable workflow with inherited secrets and inputs for chart path, component name, constructor file, and registry URL.
OCM component definition
`component-constructor.yaml`
Adds component constructor defining component github.com/platform-mesh/example-httpbin-operator v0.1.0 with two resources: Helm chart (OCI) and container image (OCI), pointing to ghcr.io references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 1cfcff2 and 89fa7f0.

📒 Files selected for processing (2)
  • .github/workflows/job-ocm.yaml (1 hunks)
  • component-constructor.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/job-ocm.yaml

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
Copy link
Copy Markdown
Contributor

@mirzakopic mirzakopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@ntnn what do you think?

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure about this. The MFP colleagues place the ocm files in .ocm, which does make sense if there are multiple components in one repo.
However I think this should be treated more like a Dockerfile, so it should be at the repo root imho.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it, had a problem with the ocm directory, but for sure we can put this at the repo root.

Comment thread ocm-config/component-constructor.yaml Outdated
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>

On-behalf-of: @SAP karol.szwaj@sap.com
@cnvergence cnvergence merged commit 3913789 into main Oct 3, 2025
7 checks passed
@cnvergence cnvergence deleted the add-ocm branch October 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants