Conversation
WalkthroughIntroduces a new GitHub Actions workflow for OCM releases and adds an OCM component constructor YAML defining the example-httpbin-operator component with Helm chart and image resources. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Free 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
mirzakopic
left a comment
There was a problem hiding this comment.
looks fine to me
@ntnn what do you think?
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
There was a problem hiding this comment.
Not so sure about this. The MFP colleagues place the ocm files in .ocm, which does make sense if there are multiple components in one repo.
However I think this should be treated more like a Dockerfile, so it should be at the repo root imho.
There was a problem hiding this comment.
I don't mind it, had a problem with the ocm directory, but for sure we can put this at the repo root.
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Summary by CodeRabbit