Skip to content

Add support for Ubuntu 24 #412

Merged
snslk merged 6 commits intomasterfrom
private/atherton/snehal/PMK-6653
Apr 26, 2025
Merged

Add support for Ubuntu 24 #412
snslk merged 6 commits intomasterfrom
private/atherton/snehal/PMK-6653

Conversation

@snslk
Copy link
Contributor

@snslk snslk commented Apr 17, 2025

  1. Added changes for supporting ubuntu 24.
  2. Onboarded ubuntu24 node to DU
ubuntu@24ubuntu:~$ bash <(curl -sL https://pmkft-assets.s3.us-west-1.amazonaws.com/pf9ctl_internal_test/pf9ctl_setup)
 ____ _    _  __           ___
| _ \| | __ _| |_ / _| ___ _ __ _ __ ___ / _ \
| |_) | |/ _` | __| |_ / _ \| '__| '_ ` _ \ (_) |
| __/| | (_| | |_| _| (_) | | | | | | | \__, |
|_|  |_|\__,_|\__|_| \___/|_| |_| |_| |_| /_/

Note: SUDO access required to run Platform9 CLI.
   You might be prompted for your SUDO password.

Downloading Platform9 CLI binary...

Platform9 CLI binary downloaded.

Installing Platform9 CLI...

Platform9 CLI installation completed successfully !

To start building a Kubernetes cluster execute:
    pf9ctl help

root@ubuntu24-1:~# ./pf9ctl prep-node
Error checking versions open /usr/bin/pf9ctl: no such file or directory
x Existing config not found, prompting for new config
Platform9 Account URL: https://test-du-qbert-bare-os-u20-3784577.platform9.horse/
Username: [pf9@platform9.com](mailto:pf9@platform9.com)
Password:
Region [RegionOne]:
Tenant [service]:
Proxy URL [None]:
MFA Token [None]:
✓ Stored configuration details successfully
✓ Loaded Config Successfully
✓ Removal of existing CLI
✓ Existing Platform9 Packages Check
✓ Required OS Packages Check
✓ SudoCheck
✓ CPUCheck
✓ DiskCheck
✓ MemoryCheck
✓ PortCheck
✓ Existing Kubernetes Cluster Check
✓ Check lock on dpkg
✓ Check lock on apt
✓ Check if system is booted with systemd
✓ Check time synchronization
✓ Check if firewalld service is not running
✓ Disabling swap and removing swap in fstab
✓ Completed Pre-Requisite Checks successfully
/ Starting prep-node 2025-04-16T07:04:34.626Z	INFO	Pf9 packages are not present
✓ Platform9 packages installed successfully
✓ Initialised host successfully
✓ Host successfully attached to the Platform9 control-plane
Screenshot 2025-04-16 at 1 01 58 PM

Summary by Bito

This PR adds Ubuntu 24 support by extending version-checking logic in the debian platform module and updating error messages in the checkNode module. It removes references to Ubuntu 18.04 while implementing conditions for Ubuntu 20.04, 22.04, and 24 across multiple code segments to ensure proper OS identification and validation. These changes are part of a broader initiative to facilitate the onboarding of Ubuntu 24 nodes.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Apr 17, 2025

Code Review Agent Run #2ddb81

Actionable Suggestions - 0
Additional Suggestions - 2
  • pkg/platform/debian/debian.go - 2
    • Duplicated version check pattern increases maintenance burden · Line 306-307
    • Redundant Ubuntu 24.04 support condition implementation · Line 414-414
Review Details
  • Files reviewed - 2 · Commit Range: ab78a87..1755899
    • pkg/platform/debian/debian.go
    • pkg/pmk/checkNode.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Apr 17, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Ubuntu 24 Support Enhancements

debian.go - Extended OS version checks and comments to include and correctly handle Ubuntu 20.04, 22.04, and 24.04.

checkNode.go - Updated error messaging to accurately reflect the supported Ubuntu versions, now including 24.04.

cruizen
cruizen previously approved these changes Apr 24, 2025
@cruizen
Copy link
Contributor

cruizen commented Apr 24, 2025

@iamajohn
Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@iamajohn
Copy link

@iamajohn Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@cruizen Please check out https://pmk-dashboard.infrastructure.rspc.platform9.horse/

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Apr 24, 2025

Code Review Agent Run #c7cc51

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 1755899..6f822ac
    • pkg/platform/debian/debian.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

@cruizen
Copy link
Contributor

cruizen commented Apr 24, 2025

@iamajohn Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@cruizen Please check out https://pmk-dashboard.infrastructure.rspc.platform9.horse/
If I use the pmk-dashboard tool , I can only select one kdu at at a time. Can we provide a way to filter by OS or a given PMK release version? e.g. How many clicks before I know how many customers are on PMK 5.6 (or earlier no to complicate it further)? Feature request for you @KarthikSaladi-pf9 ;-)

@cruizen
Copy link
Contributor

cruizen commented Apr 24, 2025

@iamajohn Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@cruizen Please check out https://pmk-dashboard.infrastructure.rspc.platform9.horse/
If I use the pmk-dashboard tool , I can only select one kdu at at a time. Can we provide a way to filter by OS or a given PMK release version? e.g. How many clicks before I know how many customers are on PMK 5.6 (or earlier no to complicate it further)? Feature request for you @KarthikSaladi-pf9 ;-)

Query mode to the rescue. HT @bharath-pf9 , thank you!

Only our ops-acceptance.platform9.net DU is on Ubuntu 18.04 Bionic Beaver, right?

@cruizen
Copy link
Contributor

cruizen commented Apr 24, 2025

@iamajohn Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@cruizen Please check out https://pmk-dashboard.infrastructure.rspc.platform9.horse/
If I use the pmk-dashboard tool , I can only select one kdu at at a time. Can we provide a way to filter by OS or a given PMK release version? e.g. How many clicks before I know how many customers are on PMK 5.6 (or earlier no to complicate it further)? Feature request for you @KarthikSaladi-pf9 ;-)

Query mode to the rescue. HT @bharath-pf9 , thank you!

Only our ops-acceptance.platform9.net DU is on Ubuntu 18.04 Bionic Beaver, right?

@jeremymv2 If we remove support for Ubuntu 18, will it affect ops-acceptance.platform9.net? Can you use an older build of pf9ctl there? Or can we upgrade this environment to use Ubuntu 22 LTS?

@iamajohn
Copy link

@iamajohn Shall we remove Ubuntu 18 from the list of supported operating systems? Are there any customers using it? https://platform9.com/docs/kubernetes/support-matrix#os-support

@cruizen Please check out https://pmk-dashboard.infrastructure.rspc.platform9.horse/
If I use the pmk-dashboard tool , I can only select one kdu at at a time. Can we provide a way to filter by OS or a given PMK release version? e.g. How many clicks before I know how many customers are on PMK 5.6 (or earlier no to complicate it further)? Feature request for you @KarthikSaladi-pf9 ;-)

Trilok plz use query mode, its straingt forward and easy

Copy link
Contributor

@bharath-pf9 bharath-pf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Apr 25, 2025

Code Review Agent Run #68303a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 6f822ac..fbd0eb8
    • pkg/pmk/checkNode.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

@cruizen cruizen self-requested a review April 26, 2025 10:45
@snslk snslk merged commit 29d292c into master Apr 26, 2025
4 checks passed
@snslk snslk deleted the private/atherton/snehal/PMK-6653 branch April 26, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants