Skip to content

#1783 : Duplicate Amplitude Events Triggered During Migration#1791

Merged
AbhijeetThakur merged 7 commits intomainfrom
private/abhijeet/amplitude-event-fixes
Apr 16, 2026
Merged

#1783 : Duplicate Amplitude Events Triggered During Migration#1791
AbhijeetThakur merged 7 commits intomainfrom
private/abhijeet/amplitude-event-fixes

Conversation

@AbhijeetThakur
Copy link
Copy Markdown
Collaborator

@AbhijeetThakur AbhijeetThakur commented Apr 7, 2026

What this PR does / why we need it

  • Extract VM names from the migration plan spec and send separate Amplitude events for each VM being migrated, including the VM name in the event properties alongside existing migration metadata.
  • Implements tracking for delete operations across VMware credentials, PCD credentials, migrations, and agents. Updates AMPLITUDE_EVENTS.md to reorganize documentation into user journey-based sections with implementation status tracking.

Which issue(s) this PR fixes

fixes #1783

Testing done

Screencast.from.09-04-26.05.29.05.PM.IST.webm
Screenshot from 2026-04-09 15-50-04

Migration with a single VM

image

@AbhijeetThakur AbhijeetThakur marked this pull request as ready for review April 9, 2026 12:03
Copy link
Copy Markdown
Collaborator

@OmkarDeshpande7 OmkarDeshpande7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown
Contributor

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
8 8 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 80b5869dbf4a48e61cc02e75edaa9222784e4eed

@AbhijeetThakur AbhijeetThakur merged commit c8e583b into main Apr 16, 2026
16 checks passed
@AbhijeetThakur AbhijeetThakur deleted the private/abhijeet/amplitude-event-fixes branch April 16, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Amplitude Events Triggered During Migration

2 participants