Skip to content

Fixed migration issue for shared rdm disk#1902

Merged
geet-pf9 merged 3 commits intomainfrom
private/geet/fixrdmmigrationstatus
May 6, 2026
Merged

Fixed migration issue for shared rdm disk#1902
geet-pf9 merged 3 commits intomainfrom
private/geet/fixrdmmigrationstatus

Conversation

@geet-pf9
Copy link
Copy Markdown
Contributor

@geet-pf9 geet-pf9 commented May 5, 2026

What this PR does / why we need it

When an ownerVM completes migration before other VMs sharing the same RDM disk are processed, the remaining VMs incorrectly showed ValidationFailed. Added isVMSucceededInPlan to skip ownerVM validation for VMs that have already succeeded in the same plan.

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #1900

Special notes for your reviewer

Testing done

image

please add testing details (logs, screenshots, etc.)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
6 6 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: d1dfd1650dd8db90a1d0ac4b1015fcdf49ef37f5

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric Count
Total Added 4
Total Fixed 0
Net Change +4

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
10 6 4 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 4 Added

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42033
Severity: HIGH
Title: axios: Axios: HTTP Transport Hijacking via Prototype Pollution

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42035
Severity: HIGH
Title: axios: Axios: Arbitrary HTTP header injection via prototype pollution

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42043
Severity: HIGH
Title: Axios is a promise based HTTP client for the browser and Node.js. Prio ...

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42264
Severity: HIGH
Title: Axios has prototype pollution read-side gadgets in HTTP adapter that allow credential injection and request hijacking


Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: d1dfd1650dd8db90a1d0ac4b1015fcdf49ef37f5

Copy link
Copy Markdown
Collaborator

@OmkarDeshpande7 OmkarDeshpande7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric Count
Total Added 4
Total Fixed 0
Net Change +4

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
10 6 4 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 4 Added

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42033
Severity: HIGH
Title: axios: Axios: HTTP Transport Hijacking via Prototype Pollution

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42035
Severity: HIGH
Title: axios: Axios: Arbitrary HTTP header injection via prototype pollution

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42043
Severity: HIGH
Title: Axios is a promise based HTTP client for the browser and Node.js. Prio ...

Target: ui/yarn.lock
Package: axios 1.13.2
Vulnerability: CVE-2026-42264
Severity: HIGH
Title: Axios has prototype pollution read-side gadgets in HTTP adapter that allow credential injection and request hijacking


Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: d1dfd1650dd8db90a1d0ac4b1015fcdf49ef37f5

@geet-pf9 geet-pf9 merged commit a37f329 into main May 6, 2026
16 checks passed
@geet-pf9 geet-pf9 deleted the private/geet/fixrdmmigrationstatus branch May 6, 2026 05:43
@sarika-pf9 sarika-pf9 removed their assignment May 6, 2026
sarika-pf9 pushed a commit that referenced this pull request May 6, 2026
Co-authored-by: OmkarDeshpande7 <omideshpande77@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration status shows "validation failed" for one VM with a multi-attach RDM. However, the migration completed successfully.

3 participants