Skip to content

update graph-maker version#124

Merged
erohinaelena merged 1 commit intomainfrom
erohinaelena/update-dependencies
Mar 4, 2026
Merged

update graph-maker version#124
erohinaelena merged 1 commit intomainfrom
erohinaelena/update-dependencies

Conversation

@erohinaelena
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a comprehensive update of various package dependencies across the project, most notably bumping the @milaboratories/graph-maker package to its latest version. This update cascades to several other internal @platforma-sdk and @milaboratories packages, ensuring compatibility and leveraging new features or fixes. Additionally, the change includes a minor refactoring of style imports in the main application entry point, streamlining the styling mechanism.

Highlights

  • Dependency Updates: Updated the @milaboratories/graph-maker package to version 1.2.1 and several related @platforma-sdk and other @milaboratories packages to their latest versions in pnpm-lock.yaml and pnpm-workspace.yaml.
  • Style Import Refactoring: Removed direct style imports for @platforma-sdk/ui-vue and @milaboratories/graph-maker from ui/src/main.ts, likely indicating a change in how styles are managed or bundled.
  • Changelog Entry: Added a new changeset file (.changeset/sixty-mirrors-tie.md) to document the graph-maker version update.
Changelog
  • .changeset/sixty-mirrors-tie.md
    • Added a new changeset file to document the version update for @platforma-open/milaboratories.graph-maker.ui.
  • pnpm-lock.yaml
    • Updated @milaboratories/graph-maker from 1.1.226 to 1.2.1.
    • Updated @platforma-sdk/model from 1.53.11 to 1.57.2.
    • Updated @platforma-sdk/ui-vue from 1.53.11 to 1.57.3.
    • Updated various other @milaboratories packages including helpers, miplots4, pf-plots, pl-error-like, pl-model-common, ptabler-expression-js, and uikit to newer versions.
    • Removed the @milaboratories/biowasm-tools@2.0.0 entry.
    • Adjusted peer dependency versions for updated packages.
  • pnpm-workspace.yaml
    • Updated @platforma-sdk/model from 1.53.11 to 1.57.2.
    • Updated @milaboratories/graph-maker from ^1.1.226 to ^1.2.1.
    • Updated @platforma-sdk/ui-vue from 1.53.11 to 1.57.3.
  • ui/src/main.ts
    • Removed direct import statements for @platforma-sdk/ui-vue/styles and @milaboratories/graph-maker/styles.
Activity
  • No specific activity (comments, reviews, etc.) was recorded or provided for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@erohinaelena erohinaelena enabled auto-merge March 4, 2026 10:06
@erohinaelena erohinaelena added this pull request to the merge queue Mar 4, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @milaboratories/graph-maker dependency, along with several @platforma-sdk packages. The changes primarily involve version bumps in pnpm-workspace.yaml and the corresponding updates in pnpm-lock.yaml. Additionally, style imports have been removed from ui/src/main.ts, which is likely correct given the new library versions. I've identified a version split for the @platforma-sdk/ui-vue package in the lockfile, which could lead to maintainability issues. A specific comment has been added with a recommendation to resolve this.

Comment on lines 112 to +114
'@milaboratories/graph-maker':
specifier: 'catalog:'
version: 1.1.226(@milaboratories/pl-model-common@1.24.3)(@platforma-sdk/model@1.53.11)(@platforma-sdk/ui-vue@1.53.11(sortablejs@1.15.6)(typescript@5.9.2))(d3-dispatch@3.0.1)(d3-path@3.1.0)(d3-scale-chromatic@3.1.0)(typescript@5.9.2)
version: 1.2.1(@milaboratories/pl-model-common@1.25.2)(@platforma-sdk/model@1.57.2)(@platforma-sdk/ui-vue@1.58.11(typescript@5.9.2))(d3-dispatch@3.0.1)(d3-path@3.1.0)(d3-scale-chromatic@3.1.0)(typescript@5.9.2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lockfile indicates that two different versions of @platforma-sdk/ui-vue (1.57.3 and 1.58.11) are being used in the workspace. This is because the model package's devDependency on @milaboratories/graph-maker has a peerDependency on @platforma-sdk/ui-vue. Since model/package.json doesn't explicitly list @platforma-sdk/ui-vue as a dependency, pnpm resolves it to a different version than the one specified in the workspace catalog.

Having multiple versions of a UI component library can increase the final bundle size and may lead to inconsistent behavior or subtle bugs.

To ensure a single version is used across the workspace, please add @platforma-sdk/ui-vue to the devDependencies of the model package, referencing the catalog version.

In model/package.json, you can add:

"devDependencies": {
  ...
  "@platforma-sdk/ui-vue": "catalog:"
}

After this change, run pnpm install to update the lockfile.

Merged via the queue into main with commit 558abb4 Mar 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant