feat: add whitelists for scipy import errors in Python 3.12.10-humanness builds#79
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the humanness whitelists for Python 3.12.10 on both linux-aarch64 and linux-x64 platforms. Specifically, it adds an entry for scipy-1.*.whl to ignore a partial initialization import error in scipy.linalg._matfuncs_sqrtm_triu. There are no review comments, and I have no additional feedback to provide.
mzueva
approved these changes
May 27, 2026
…thon 3.12.10-humanness builds
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds scipy import error whitelists for the
python-3.12.10-humannessbuild onlinux-aarch64andlinux-x64, whitelisting the knownscipy.linalg._matfuncs_sqrtm_triucircular-import failure.scipy.linalg._matfuncs_sqrtm_triuunderscipy-1.*.whl, consistent with other builds.sccoda,h5ad) also whitelistsscipy.stats._unuran.unuran_wrapperfor the'SeedlessSequence'numpy compatibility error — and themacosx-aarch64.jsonfor this same humanness build includes both entries. It's worth confirming whether the Linux humanness build uses a newer numpy that avoids this error, or whether the second entry is missing.Confidence Score: 4/5
Safe to merge if the humanness Linux build intentionally uses a numpy version that avoids the unuran_wrapper error; otherwise the checker may silently miss a known failure.
The changes are minimal whitelist JSON additions. The only concern is that
scipy.stats._unuran.unuran_wrapperis whitelisted in every other Linux scipy entry in the repo (and in the macOS counterpart for this very build), but is absent from the two new Linux files. If the humanness build's numpy version on Linux does exhibit this error, it would be treated as unexpected by the checker.Both
linux-aarch64.jsonandlinux-x64.json— confirm whether theunuran_wrapperentry should be present, consistent with all other Linux scipy whitelists.Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[scipy-1.*.whl import check] --> B{Platform} B --> |linux-x64 / linux-aarch64| C[Whitelist lookup] B --> |macosx-aarch64| D[Whitelist lookup] C --> E[scipy.linalg._matfuncs_sqrtm_triu ✅ whitelisted] C --> F[scipy.stats._unuran.unuran_wrapper ❓ NOT whitelisted] D --> G[scipy.linalg._matfuncs_sqrtm_triu ✅ whitelisted] D --> H[scipy.stats._unuran.unuran_wrapper ✅ whitelisted] F --> I{Does error occur on Linux?} I -->|Yes - numpy older| J[Checker flags as unexpected failure] I -->|No - newer numpy| K[No issue]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat: add whitelists for scipy import er..." | Re-trigger Greptile