Skip to content

Revert MILAB-6205: freesasa 2.2.1 (Windows runenv build failed)#87

Merged
xnacly merged 1 commit into
mainfrom
revert-pr-86-freesasa
Jun 2, 2026
Merged

Revert MILAB-6205: freesasa 2.2.1 (Windows runenv build failed)#87
xnacly merged 1 commit into
mainfrom
revert-pr-86-freesasa

Conversation

@xnacly
Copy link
Copy Markdown
Contributor

@xnacly xnacly commented Jun 2, 2026

Reverts #86 to restore main's build.

Why

freesasa's buildWheel compiled and passed the native-import check on 4 of 5 platforms (linux-x64, linux-aarch64, macOS-x64, macOS-arm64). The MSVC build on windows-latest failed, so the python-3.12.10 Build NPM package job went red on main.

Plan to re-land

Re-add freesasa with a Windows-specific buildWheel entry (the linux/macOS entries were fine). Likely the same approach kalign uses: build with clang-cl + Ninja and pass configSettings, or otherwise adjust the MSVC compile. Will reopen under MILAB-6205 once the Windows build is sorted.

Greptile Summary

This PR reverts #86, removing freesasa==2.2.1 and its associated buildWheel configuration from the Python 3.12.10 run environment after the Windows (windows-latest) MSVC build failed, breaking main.

  • Removes freesasa==2.2.1 from python-3.12.10/config.json dependencies and the entire buildWheel block that specified C-extension compilation for all five platforms.
  • Deletes the .changeset/milab-6205-freesasa.md changeset file, cleanly unwinding the original PR's version bump.
  • The revert leaves the file without a trailing newline (minor style nit), but otherwise the rollback is complete and correct.

Confidence Score: 5/5

This is a clean revert that restores main to its pre-freesasa state; no logic changes, no regressions introduced.

The change removes two additions (a dependency entry and its buildWheel block) and deletes a changeset file — all exactly matching the inverse of #86. The only artifact worth noting is the missing trailing newline in config.json, which has no runtime impact.

No files require special attention; the revert is mechanically straightforward.

Important Files Changed

Filename Overview
.changeset/milab-6205-freesasa.md Changeset file for the freesasa addition is deleted as part of the revert — correct and expected.
python-3.12.10/config.json Removes freesasa==2.2.1 from dependencies and the entire buildWheel section; file is left without a trailing newline.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #86: Add freesasa 2.2.1] -->|Windows MSVC build failed| B[main broken]
    B --> C[PR #87: Revert freesasa addition]
    C --> D[Remove freesasa==2.2.1 from dependencies]
    C --> E[Remove buildWheel section for freesasa]
    C --> F[Delete changeset file]
    D & E & F --> G[main restored]
    G --> H[Future: Re-land with Windows-specific buildWheel fix]
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
python-3.12.10/config.json:42-44
The file is missing a trailing newline. Most editors and POSIX tools expect text files to end with a newline, and the absence is flagged by `git diff` with `\ No newline at end of file`.

```suggestion
    "overrides": {}
  }
}
```

Reviews (1): Last reviewed commit: "Revert MILAB-6205: freesasa 2.2.1 (Windo..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Reverts #86. freesasa's buildWheel succeeded on linux-x64/aarch64 and macOS x64/arm64, but the MSVC compile failed on windows-latest, turning main's build red. Reverting to restore main; will re-land with a Windows-specific buildWheel fix (clang-cl / config-settings, as kalign does).
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the freesasa dependency and its corresponding platform-specific wheel build configurations from the Python 3.12.10 run environment configuration. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +42 to 44
"overrides": {}
}
} No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline. Most editors and POSIX tools expect text files to end with a newline, and the absence is flagged by git diff with \ No newline at end of file.

Suggested change
"overrides": {}
}
}
"overrides": {}
}
}
Prompt To Fix With AI
This is a comment left during a code review.
Path: python-3.12.10/config.json
Line: 42-44

Comment:
The file is missing a trailing newline. Most editors and POSIX tools expect text files to end with a newline, and the absence is flagged by `git diff` with `\ No newline at end of file`.

```suggestion
    "overrides": {}
  }
}
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@xnacly xnacly merged commit d40584c into main Jun 2, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants