Skip to content

[canary] changeset-coverage devDependency fix — do not merge#14

Closed
PaulNewling wants to merge 1 commit into
mainfrom
canary/changeset-coverage-devdeps
Closed

[canary] changeset-coverage devDependency fix — do not merge#14
PaulNewling wants to merge 1 commit into
mainfrom
canary/changeset-coverage-devdeps

Conversation

@PaulNewling
Copy link
Copy Markdown
Collaborator

Throwaway canary — do not merge. Close after the CI signal is read.

Validates the fix on milaboratory/github-ci@v4-beta that scopes the changeset-coverage check's catalog rule to runtime deps only, so build-tool catalog bumps in devDependencies stop producing false positives.

What this PR reproduces

  • Edits only the UI (ui/src/main.ts).
  • Bumps the catalog pins for the two build tools consumed as devDependencies: @platforma-sdk/block-tools and @platforma-sdk/tengo-builder (pin → caret; same resolved versions, lockfile updated to match).
  • Adds a changeset for the UI package only.
  • Pins build.yaml to node-simple-pnpm.yaml@v4-beta to exercise the fix.

What to check

The changeset coverage (diagnostic) check should be green. On @v4 it would flag …model (block-tools) and …workflow (tengo-builder) as "modified but not bumped" even though only the UI changed. With the fix those devDependency consumers are no longer flagged; the UI changeset satisfies coverage.

Cleanup

Close without merging; the @v4-beta pin in build.yaml must not reach main.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a canary change to verify that the changeset-coverage check no longer flags model or workflow packages when build-tool devDependencies are bumped. It updates the version specifiers for @platforma-sdk/block-tools and @platforma-sdk/tengo-builder to use caret ranges in pnpm-workspace.yaml and pnpm-lock.yaml, and adds a temporary canary comment in ui/src/main.ts. There are no review comments, and I have no feedback to provide.

@PaulNewling
Copy link
Copy Markdown
Collaborator Author

Canary green: changeset coverage (diagnostic) step succeeded — '✓ Changeset covers every modified package.' with block-tools/tengo-builder catalog bumped (devDeps) and only the UI touched. Fix on github-ci@v4-beta validated. Closing throwaway.

@PaulNewling PaulNewling deleted the canary/changeset-coverage-devdeps branch May 29, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant