Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix
run --stopfailing to terminate worker processes (Account.Workers, BackOffice.Workers, Main.Workers) on Linux/macOS. After stopping, these processes remained listening on their ports indefinitely.The previous stop logic used a two-loop approach that had two compounding bugs:
ps -o comm=which truncates binary names on Linux (e.g.,BackOffice.Workinstead ofBackOffice.Workers), causing substring checks like"PlatformP"to miss thempkill -9 -f aspireandpkill -9 -f dcpfallback calls killed ALL Aspire/dcp processes system-wide, which is unsafe when running multiple Aspire projectsReplace the entire approach with a single loop that uses
ps -o args=(full command line) and matches againstConfiguration.SourceCodeFolder. This reliably catches all application processes regardless of binary name or port, while being safe for multi-project setups since each project has a unique source folder path.Checklist