Skip to content

Fix Aspire AppHost not building email templates before APIs become ready #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjementum merged 2 commits into from
May 4, 2026
Merged

Fix Aspire AppHost not building email templates before APIs become ready #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8028f01
Build email templates as part of turbo dev:setup so APIs can render e…
tjementum May 4, 2026
5d67672
Fix UnknownUser e2e assertions for both en-US and da-DK after the Sla…
tjementum May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions application/account/WebApp/tests/e2e/localized-email-flows.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,10 @@ test.describe("@comprehensive", () => {
await step("Fetch en-US unknown user email from Mailpit & assert subject, HTML, and plaintext")(async () => {
const mail = await fetchLatestMailByRecipient(enUnknownEmail);

expect(mail.subject).toBe("Unknown user tried to login to PlatformPlatform");
expect(mail.html).toContain("You or someone else tried to login to PlatformPlatform");
expect(mail.subject).toBe("No account found");
expect(mail.html).toContain("Is this the right email address?");
expect(mail.html).toContain(enUnknownEmail);
expect(mail.text).toContain("You or someone else tried to login to PlatformPlatform");
expect(mail.text).toContain("Is this the right email address?");
expect(mail.text).toContain(enUnknownEmail);
})();

Expand All @@ -261,10 +261,10 @@ test.describe("@comprehensive", () => {
async () => {
const mail = await fetchLatestMailByRecipient(daUnknownEmail);

expect(mail.subject).toBe("Ukendt bruger forsøgte at logge ind på PlatformPlatform");
expect(mail.html).toContain("Du eller en anden forsøgte at logge ind på PlatformPlatform");
expect(mail.subject).toBe("Ingen konto fundet");
expect(mail.html).toContain("Er det den rigtige e-mailadresse?");
expect(mail.html).toContain(daUnknownEmail);
expect(mail.text).toContain("Du eller en anden forsøgte at logge ind på PlatformPlatform");
expect(mail.text).toContain("Er det den rigtige e-mailadresse?");
expect(mail.text).toContain(daUnknownEmail);
}
)();
Expand Down
2 changes: 1 addition & 1 deletion application/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"dependsOn": ["dev:setup"]
},
"dev:setup": {
"dependsOn": ["^dev:setup"],
"dependsOn": ["^dev:setup", "@repo/emails#build"],
"inputs": ["$TURBO_DEFAULT$", "shared/lib/api/*.Api.json", "shared/lib/api/*.Api_*.json"],
"outputs": ["dist/**", "shared/lib/api/*.generated.d.ts"]
},
Expand Down
Loading