Skip to content

Add CI workflow for developer CLI and tighten frontend-quality gates#890

Merged
tjementum merged 8 commits intomainfrom
pp-1187-create-github-action-workflow-for-developer-cli
May 9, 2026
Merged

Add CI workflow for developer CLI and tighten frontend-quality gates#890
tjementum merged 8 commits intomainfrom
pp-1187-create-github-action-workflow-for-developer-cli

Conversation

@tjementum
Copy link
Copy Markdown
Member

Summary & Motivation

Bring the developer CLI under CI and close two gaps in the existing frontend pipeline.

  • Add .github/workflows/developer-cli.yml that runs build, format, and lint on the developer CLI whenever files under developer-cli/** change. Mirrors the backend pattern from main.yml and skips the CLI's self-rebuild path with DEVELOPERCLI_SKIP_CHANGE_DETECTION=1. Make it a required check on main to gate merges.
  • Add a frontend formatting diff check to main.yml and account.yml (run npm run format then git diff --exit-code). The backend already had this; the frontend only ran lint, so oxfmt/oxlint --fix drift could land silently.
  • Replace the AI-driven translate developer-CLI command with a missing-translation check inside lint --frontend. The check parses every non-en-US .po file (excluding node_modules) with Karambolo.PO and fails with a per-file count when entries have empty msgstr. Drops the translate command and its OpenAI/Azure dependency closure (Azure.AI.OpenAI, Microsoft.Extensions.AI{,.OpenAI}, OpenAI). Karambolo.PO is kept for the new check; SecretHelper is kept since downstream projects may use it.
  • Fill in the existing 26 missing Danish translations in account/WebApp and account/BackOffice so the new check passes on this branch.
  • Drop dotCover from the PR workflows in main.yml / account.yml. SonarCloud's static analysis stays; coverage is not enforced on PRs. Re-introducing coverage on main (full-backend, no TypeScript) is tracked separately.
  • Drop the now-stale Coverage badge from README.md since coverage is no longer produced on every PR.
  • Drop the redundant forcePrompt: named argument in InstallCommand.GitHooksSync.Sync(true) so JetBrains cleanup doesn't rewrite it under the new format gate.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label May 9, 2026
@tjementum tjementum requested a review from a team as a code owner May 9, 2026 22:23
@tjementum tjementum added the Enhancement New feature or request label May 9, 2026
@tjementum tjementum self-assigned this May 9, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 9, 2026

PP-1187

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@tjementum tjementum merged commit c61382c into main May 9, 2026
27 checks passed
@tjementum tjementum deleted the pp-1187-create-github-action-workflow-for-developer-cli branch May 9, 2026 22:33
@github-project-automation github-project-automation Bot moved this to ✅ Done in Kanban board May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant