Fix Scoop dependency in extras #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akalipetis
commented
May 6, 2025
akalipetis
commented
- fix goreleaser scoop config
- check goreleaser config in the CI
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the Scoop dependency configuration in the goreleaser setup and adds a CI check for the goreleaser configuration.
- Fixes the dependency reference in the scoop configuration by replacing vcredist2022 with extras/vcredist2022 and removing redundant pre_install scripts.
- Introduces a new CI step to check the goreleaser configuration.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .goreleaser.yaml | Updates scoop dependency configuration to use extras/vcredist2022 and removes the pre_install script block. |
| .github/workflows/ci.yml | Adds a CI step to run a make target for validating the goreleaser configuration. |
Files not reviewed (1)
- Makefile: Language not supported
pjcdawkins
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.