Conversation
Contributor
|
Please also add an entry for this to the changelog |
Crell
reviewed
Nov 17, 2020
0ce8db4 to
9a0c9e5
Compare
9a0c9e5 to
383c3e0
Compare
GH actions Co-authored-by: chadcarlson <chad.carlson@platform.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tools such as create-react-app only expose specifically prefixed environment variables (for CRA, it's
REACT_APP_) and do so only at build time. Since Create React App produces a static HTML/CSS/JS bundle, it can’t possibly read them at runtime.This is problematic when we need access to
PLATFORM_*environment variables.To do so, we need to be able to specify a custom prefix so we can pick up the re-exported relevant variables with the prefix.
Then we can do:
.platform.app.yaml
somewhere.js