Merged
Conversation
added 11 commits
February 11, 2019 10:59
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Crell
reviewed
Feb 13, 2019
Contributor
|
Mostly style feedback. Otherwise it looks like a faithful port; good job. I defer to @NickAnderegg on the Pythonic conformity. Also, I know Python has a half dozen test frameworks. Which one are we using mostly? Is that the one used here? (I have no idea, but we should probably follow what Engineering is doing.) |
added 8 commits
February 13, 2019 10:55
…ade consistent with existing, purge white space, RuntimeError typo
Contributor
Author
|
@Crell I am using the standard unittest at the moment. |
NickAnderegg
suggested changes
Feb 13, 2019
NickAnderegg
suggested changes
Feb 13, 2019
added 11 commits
February 13, 2019 14:13
NickAnderegg
suggested changes
Feb 13, 2019
added 10 commits
February 13, 2019 16:52
NickAnderegg
approved these changes
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First big port of platformsh-config-reader-php to Python