Fix getAccessToken() return type#103

Merged

miguelsanchez-upsun merged 1 commit into3.xfrom

fix-getaccesstoken-type

Mar 20, 2026

Collaborator

pjcdawkins commented Mar 20, 2026

Summary

Fix Connector::getAccessToken() return type from false|string to ?string
Session::get() returns null when the key is absent, but the declared type did not include null
The method never returned false; removing it from the union is a correction, not a behavior change

Test plan

Verify CLI auth with no cached session (e.g. fresh container with PLATFORMSH_CLI_TOKEN)
Confirm existing session-based auth still works

Generated with Claude Code


          fix: incorrect type hint on getAccessToken

bb5a6cc

miguelsanchez-upsun merged commit 61c1a74 into 3.x

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet