Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix/enable GQA (grouped-query attention) modeling by threading a num_kv_heads parameter through the LLM attention op generators, updating attention block tensor shapes to reflect Q-heads vs KV-heads, and relaxing FlashAttention shape assumptions to permit Q_heads != KV_heads.
Changes:
- Add
num_kv_headsplumbing across attention entrypoints (create_multi_head_attention*) and propagate it fromLLMOpsGenerator. - Update normal/self-attention (fwd/bwd) and flash-attention blocks to use KV-head shapes where applicable.
- Relax FlashAttention shape assertions to only require
K_heads == V_heads(allowing GQA/MQA).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
neusim/npusim/frontend/llm_ops_lib.py |
Adds num_kv_heads throughout attention construction and introduces GQA-shaped einsums/softmax for attention blocks. |
neusim/npusim/frontend/llm_ops_generator.py |
Passes self.num_kv_heads into attention creation for prefill/decode and fwd/bwd generation paths. |
neusim/npusim/backend/npusim_lib.py |
Relaxes FlashAttention head-count assertion to allow Q-heads to differ from KV-heads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.