Skip to content

Comments

Fix pageviews slider#5209

Merged
apata merged 2 commits intomasterfrom
fix-pageviews-slider
Mar 26, 2025
Merged

Fix pageviews slider#5209
apata merged 2 commits intomasterfrom
fix-pageviews-slider

Conversation

@apata
Copy link
Contributor

@apata apata commented Mar 18, 2025

Changes

  • Fixes the pageviews slider on Firefox by aligning the base of the range input with the base of various texts that appear next to it.
    • For that, it needs to have same top and bottom margin and vertical-align: middle, which I opted to give using style not TW classes, just to keep it the same as in website #pricing section.
  • Stops slider output text from wrapping around the 1024px screen width mark by changing the font size and removing custom large screen horizontal padding from choose plan page.

See comment for before / after images.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@apata apata requested a review from a team March 18, 2025 11:08
@apata apata added the preview label Mar 18, 2025
@github-actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-5209

@apata apata requested review from RobertJoonas and ukutaht and removed request for RobertJoonas March 25, 2025 08:07
@apata apata added this pull request to the merge queue Mar 26, 2025
Merged via the queue into master with commit 5d96620 Mar 26, 2025
9 checks passed
@apata apata deleted the fix-pageviews-slider branch February 11, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants