APIv2: Fix autocomplete in Stats API playground #5286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters autocomplete only showed `"is", "segment"` under autocomplete instead of all options. This is due to limitations in the vscode autocomplete package which I don't fully understand but have to do with partially overlapping `oneOf` definitions. As such the fix was to make each `oneOf` element as independent of each other as possible. Basecamp ref: http://localhost:8001/docs/stats-api-playground
macobo
force-pushed
the
apiv2-fix-autocomplete
branch
from
50ac908 to
8a0907f
Compare
RobertJoonas
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters autocomplete only showed
"is", "segment"under autocomplete instead of all options. This is due to limitations in the vscode autocomplete package which I don't fully understand but have to do with partially overlappingoneOfdefinitions. As such the fix was to make eachoneOfelement as independent of each other as possible.To test this, run plausible/docs under port 8001 with caddy and check out this autocompletion:
Basecamp ref: https://3.basecamp.com/5308029/buckets/36789884/card_tables/cards/8515448386