FULL join for time:hour as well as time:minute #5715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
follow-up-full-join-time-hour
branch
from
a5891bf to
0397fc3
Compare
Follow-up to https://github.com/plausible/analytics/pull/5694/files#r2321567271 A session might be active over multiple hours, but not (currently) reported as such when requesting only specific metrics per hour. This fixes that problem.
macobo
force-pushed
the
follow-up-full-join-time-hour
branch
from
0397fc3 to
7a1a907
Compare
macobo
force-pushed
the
follow-up-full-join-time-hour
branch
from
28887ea to
908e864
Compare
|
ukutaht
approved these changes
Sep 15, 2025
Contributor
ukutaht
left a comment
ukutaht
left a comment
There was a problem hiding this comment.
Code looks good, hourly stats on staging look good. Merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to https://github.com/plausible/analytics/pull/5694/files#r2321567271
A session might be active over multiple hours, but not (currently) reported as such when requesting only specific metrics per hour. This fixes that problem.
Small risk deploying this PR that some time series related stats change due to unexpected consequences.