ConsolidatedView.Cache - first pass
#5748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
force-pushed
the
consolidated-cache
branch
from
68b78f9 to
b7946f4
Compare
zoldar
approved these changes
Sep 25, 2025
Courtesy by @zoldar Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
Member
Author
|
oof wait this is fun 09:41:57.022 [error] Error refreshing 'consolidated_views' - %Postgrex.Error{message: nil, postgres: %{code: :internal_error, line: "1194", message: "invalid memory alloc request size 1073741824", file: "mcxt.c", unknown: "ERROR", severity: "ERROR", pg_code: "XX000", routine: "repalloc"}, connection_id: 236, query: nil} |
…g?)" This reverts commit 03d18bc.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Looking good! Some questions in line.
|
|
||
| @impl true | ||
| def get_from_source(consolidated_view_id) do | ||
| ConsolidatedView.get(consolidated_view_id) |
Contributor
There was a problem hiding this comment.
This should be ConsolidatedView.site_ids I think?
Member
Author
There was a problem hiding this comment.
yes, excellent, will update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This lets us have an interface to lookup regular site ids per consolidated view id efficiently. I don't think it needs more tests coverage at this point - since all the caches and their common characteristics are thoroughly tested elsewhere.
Tests
Changelog
Documentation
Dark mode