Add controller-level tests for timezone handling in Query#5809
Merged
Add controller-level tests for timezone handling in Query#5809
Conversation
aerosol
approved these changes
Oct 20, 2025
Member
aerosol
left a comment
There was a problem hiding this comment.
Nice one! I admit I haven't checked if the comments are true though 😅
Contributor
Author
Fair, but I've verified that each test has a corresponding piece of production code that will cause the test to fail if the implementation changes. So we know that the tests are actually testing something :) |
Member
|
I'll merge since it fell out of the queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From conversations with @aerosol we probably want to refactor Query internals to use NaiveDateTime so we don't carry around useless and confusing timezone information in the
Querydatetimes.This PR adds some tests that give guardrails and increase confidence in timezone behaviour that is observable to clients:
todayshould be the current day in the site's timezone, not utc. Previously untested.