Merged
Conversation
aerosol
reviewed
Oct 22, 2025
| code: @puppeteer_wrapper_code, | ||
| context: %{ | ||
| url: url, | ||
| url: Plausible.InstallationSupport.URL.bust_url(url), |
Member
There was a problem hiding this comment.
won't that render the whole cache busting step redundant?
Contributor
Author
There was a problem hiding this comment.
Thanks! There's two Checks pipelines now and an attempt to diagnose cache issues is made only in Verification.Checks, not in Detection.Checks.
In the detection pipeline, we 1) verify the URL 2) (if URL is legit) have Browserless.io visit the website to sniff for legacy installation, wordpress, gtm signals.
aerosol
approved these changes
Oct 22, 2025
RobertJoonas
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Needed because our Wordpress plugin renders plugin meta HTML only when the query parameter is present.
Tests
Changelog
Documentation
Dark mode