Skip to content

Script v2: Identify detection attempt#5818

Merged
apata merged 3 commits intomasterfrom
script-v2/identify-detection-attempt
Oct 22, 2025
Merged

Script v2: Identify detection attempt#5818
apata merged 3 commits intomasterfrom
script-v2/identify-detection-attempt

Conversation

@apata
Copy link
Copy Markdown
Contributor

@apata apata commented Oct 21, 2025

Changes

Needed because our Wordpress plugin renders plugin meta HTML only when the query parameter is present.

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

code: @puppeteer_wrapper_code,
context: %{
url: url,
url: Plausible.InstallationSupport.URL.bust_url(url),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't that render the whole cache busting step redundant?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's two Checks pipelines now and an attempt to diagnose cache issues is made only in Verification.Checks, not in Detection.Checks.

In the detection pipeline, we 1) verify the URL 2) (if URL is legit) have Browserless.io visit the website to sniff for legacy installation, wordpress, gtm signals.

@apata apata marked this pull request as ready for review October 22, 2025 08:05
@apata apata added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@apata apata added this pull request to the merge queue Oct 22, 2025
Merged via the queue into master with commit f01ce1b Oct 22, 2025
16 checks passed
@RobertJoonas RobertJoonas deleted the script-v2/identify-detection-attempt branch October 22, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants