Clean up legacy verification code and script v2 flag#5824
Merged
RobertJoonas merged 26 commits intomasterfrom Oct 27, 2025
Merged
Clean up legacy verification code and script v2 flag#5824RobertJoonas merged 26 commits intomasterfrom
RobertJoonas merged 26 commits intomasterfrom
Conversation
Otherwise, it can sometimes remain unclear in the diagnostics, whether it was InstallationV2 or InstallationV2CacheBust that timed out.
The current production logs show two types of verification timeouts: * service_error: "Unhandled Browserless response status: 408" (vast majority of cases) * service_error: :timeout (only a few cases) The latter happens when we hit the Req receive_timeout (endpoint_timeout + 2s). I've seen Browserless not respect the timeout param from time to time, so it's better to keep the timeout logic "in-house" only.
...but still consider them "unhandled" for telemetry, also notifying Sentry and logging the warning.
Also rename current liveview modules and routes, removing the v2 suffix
Also fix dockerignore and elixir.yml referencing a wrong priv path
apata
added
bug
|
1 similar comment
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Note: reviewing commit by commit highly recommended.
This PR removes a bunch of code related to legacy verification, both JS and Elixir. Also gets rid of
:scriptv2feature flag.Tests
Change-log
Documentation
Dark mode