Verification / Detection follow-ups#5836
Conversation
03c3bd2 to
1436c0d
Compare
... make it sync and test capturing Sentry events too
1436c0d to
e998ae5
Compare
| @@ -0,0 +1,188 @@ | |||
| defmodule Plausible.InstallationSupport.Verification.ChecksObservabilityTest do | |||
There was a problem hiding this comment.
suggestion, non-blocking: checks_test, checks_observability_test for both Verification and Detection have quite a bit of similar code, like stubbing, test sentry conf, run_checks, test scenarios.
I think we could cut down on this duplication a lot by doing the following:
In the main checks_test modules, we make sure that expected %Result's are achieved.
In o11y-related unit tests, we make sure that given certain %Result's, handle_result triggers certain logs, metrics etc
There was a problem hiding this comment.
Fair suggestion by all means, but I personally like how these tests do not worry about any intermediate results and focus solely on how a certain Browserless response gets handled. They're still fast, cheap and easy to follow.
Changes
Note: This PR makes the
timeout_ms(that is currently fixed for each InstallationSupport.Check module) configurable on the CheckRunner level. This will also be useful for increasing detection timeout for the domain change flow.Tests
Changelog
Documentation
Dark mode