Add usage notifications for billing limits#6056
Merged
Conversation
- As a first step towards improving the subscription settings page, this commit adds usage notifications for billing limits. These are not yet being displayed in the UI.
sanne-san
force-pushed
the
sanne-billing-notifications
branch
from
4fe93b2 to
0936c29
Compare
sanne-san
force-pushed
the
sanne-billing-notifications
branch
from
4d89e7b to
db8fa96
Compare
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
I like where we're going with this! As you've probably realized, the billing logic is incredibly complex and there are a lot of different considerations at every step. So even a small PR like this has a bunch of comments 😄
PS: The screen recordings you shared are 💯👌! Excited to see those changes in :)
- Move `determine_notification_type` function from Notice component to `Plausible.Billing.Quota` - Rename `determine_notification_type` to `usage_notification_type` - Cut down on the number of arguments to make the `usage_notification_type` function more readable - Add public `has_billing_cycles` predicate function - Update `exceeds_last_two_usage_cycles` to use `has_billing_cycles` - Extract `pageview_cycle_usage_notification_type` for pageview limit notifications - Rename :limits_reached_combined to :site_and_team_member_limit_reached - Update all tests to use realistic data structures
RobertJoonas
approved these changes
Feb 11, 2026
- Split traffic_exceeded_sustained into base notification and grace_period_active variant - Add GracePeriod.days_left/1 to calculate remaining days in grace period - Display "within the next X days" for active grace periods
sanne-san
force-pushed
the
sanne-billing-notifications
branch
from
d0efcd2 to
197febf
Compare
Co-authored-by: RobertJoonas <56999674+RobertJoonas@users.noreply.github.com>
grace period end in hours + remove unused fn
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
- Enterprise manual locks (no end date) now use separate notification without countdown, while regular grace periods show dynamic "within X days/hours". - Update exceeded_cycles to support checking with or without allowance margin.
RobertJoonas
approved these changes
Feb 16, 2026
Co-authored-by: RobertJoonas <56999674+RobertJoonas@users.noreply.github.com>
sanne-san
force-pushed
the
sanne-billing-notifications
branch
from
217fb01 to
20db67e
Compare
- A manual lock can be triggered not only due to pageview limit, but also due to site limit. For this reason, it needs a separate notification with copy that fits both use cases.
sanne-san
force-pushed
the
sanne-billing-notifications
branch
from
20db67e to
90dddfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode