Conversation
|
aerosol
approved these changes
Apr 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
zoldar
deleted the
exploration-stop-order-by-name-pathname-in-steps-query-windows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Another go at optimising performance of the suggestion query. This time we avoid ordering by name and pathname in the innermost, window queries. Stable ordering is ensured by enumerating by row_number() in the inner window and using it for sortin in the outer window, in addition to the timestamp. Very rarely, there's an artifact of a suggestion identical to the previous step appearing but it has 0 visitors - it's most likely due to union -> "smart join" optimisation done earlier.