Pass segment timestamps in site timezone#6286
Merged
Conversation
apata
force-pushed
the
segments-timestamps-to-site-tz
branch
from
2e49f68 to
2214990
Compare
apata
changed the title
apata
force-pushed
the
segments-timestamps-to-site-tz
branch
from
6630b37 to
8188f02
Compare
|
RobertJoonas
reviewed
May 4, 2026
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Looks good to me! But could we also add a test to actually assert on the timestamps being shifted into site timezone when passed to the frontend?
ukutaht
approved these changes
May 4, 2026
RobertJoonas
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The frontend doesn't have enough information to render the UTC timestamps sent to it correctly.
Site timezone offset isn't enough, because the offset is dynamic. It depends on the time.
For example, for a site with the timezone Tallinn/Estonia, the UTC datetime
2026-01-01T00:00:00must be rendered as2026-01-01 02:00:00whereas2026-04-01T00:00:00must be rendered as2026-04-01 03:00:00.This problem manifests with segment related timestamps: if the user on the Tallinn/Estonia site creates a segment in January and looks at it in April, the shown timestamp will be off by one hour, because we use the offset right now.
This PR fixes it by converting the dates on the backend.
The alternative would be to provide the timezone locale to the FE and use that. The issue with that is the tz database falling out of sync between the BE and the FE. Also, we already convert some dates on the backend (in queries with the time dimension).
Tests
Changelog
Documentation
Dark mode