Show provisional visitors instantly after switching candidate#6295
Merged
Show provisional visitors instantly after switching candidate#6295
Conversation
|
zoldar
approved these changes
Apr 30, 2026
aerosol
force-pushed
the
fix-flashing-visitors
branch
from
4b0636d to
574bcad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a new candidate is selected in an already occupied column,
funnel[i]still holds the old funnel data (the new funnel hasn't loaded yet). Sofunnel[i].visitorsis truthy and shadows the newly setprovisionalFunnelEntries[i].visitors, causing the old visitor count to flash until the API response arrives.This PR fixes it by making
provisionalFunnelEntriestake precedence over the stale funnel data.