Standardize all filter and segment modals styles#6298
Merged
Conversation
- Add a shared ModalLayout/ModalFooter to give every modal the same header, body spacing, and button alignment - Add a shared Button component (matching the Phoenix variant) and switch all modal buttons to it for consistent sizing and theming - Align footer buttons to the right in all modal footers - Restructure the segment details modal: fixed "Segment details" title, with the segment name, type, and authorship shown inline in the body - Update the delete segment modal with a clearer title and a confirmation message - Make filter pills better visible inside modals with a gray background - Add a Cancel button to the filter modal when no filters are applied - Refine button theme borders so ghost, yellow, and icon variants line up at the same height as bordered buttons, and fix the visible border on disabled primary buttons
sanne-san
force-pushed
the
sanne-dashboard-modals
branch
from
f760230 to
eed180e
Compare
apata
added
bug
|
1 similar comment
|
apata
reviewed
Apr 30, 2026
apata
reviewed
Apr 30, 2026
apata
approved these changes
Apr 30, 2026
Contributor
apata
left a comment
apata
left a comment
There was a problem hiding this comment.
Vast improvement, good job!
- Move shared button styles into `.btn-*` Tailwind component classes used by both the React Button and the Phoenix `button` component - Tweak filter pill styling inside modals for dark mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode