Serve exploration config to the front-end#6352
Merged
Merged
Conversation
|
zoldar
approved these changes
May 14, 2026
Comment on lines
+12
to
+16
| explorationJourneyEndEvent: dataset.explorationJourneyEndEvent ?? '', | ||
| explorationMaxJourneySteps: parseInt( | ||
| dataset.explorationMaxJourneySteps ?? '0', | ||
| 10 | ||
| ), |
Contributor
There was a problem hiding this comment.
AFAIU, the fallbacks are here mostly to avoid issues during rolling release right? We might want to make those properties asserted as non-null with "!" later on.
Comment on lines
+1040
to
+1041
| JOURNEY_END_EVENT, | ||
| MAX_JOURNEY_STEPS |
Contributor
There was a problem hiding this comment.
Are they really necessary as effect dependencies? 🤔
| colIndex, | ||
| onSelect | ||
| }) { | ||
| const { explorationJourneyEndEvent: JOURNEY_END_EVENT } = useSiteContext() |
Contributor
There was a problem hiding this comment.
IMHO it's better to use journeyEndEvent and maxJourneySteps, event if those variables extracted from context are constants. Uppercase convention is AFAIK expected for locally declarted constants and that might throw someone reading the code off and wonder where it's coming from.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.