[codex] Fix RowBinary benchmark workflow env#350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the RowBinary benchmark GitHub Actions job from
MIX_ENV=benchtoMIX_ENV=dev.Why
The benchmark scripts depend on modules under
dev/support, includingCh.Bench.RowBinaryBenchmarkDataandGitHubActionBenchmarkFormatter. The project already compiles those support modules and includes Benchee in thedevenvironment. Running the workflow withMIX_ENV=benchskipped that setup and caused the encode/decode benchmark jobs to fail before running.Validation
MIX_ENV=dev mix deps.get --only devMIX_ENV=dev mix compile --warnings-as-errorsMIX_ENV=dev mix run -e 'alias Ch.Bench.RowBinaryBenchmarkData; alias Ch.RowBinary; types = RowBinaryBenchmarkData.types(); rows = RowBinaryBenchmarkData.rows(10); encoded = RowBinary.encode_rows(rows, types) |> IO.iodata_to_binary(); true = RowBinary.decode_rows(encoded, types) == rows; true = Code.ensure_loaded?(GitHubActionBenchmarkFormatter); IO.puts("dev benchmark support OK")'