Fix HTTP deadline roundtrip property#363
Merged
ruslandoga merged 1 commit intoMay 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the HTTP deadline roundtrip property to use assert_in_delta for the timestamp comparison. The previous asymmetric bounds could fail when the timeout-to-deadline conversion read the monotonic clock one millisecond later than the original deadline calculation. This keeps the implementation unchanged and makes the property reflect the existing 50 ms tolerance. Validated with mix test test/ch/http_test.exs --seed 0 and mix test.