fix: prevent light icon loading as gray square#1717
Merged
willeastcott merged 5 commits intomainfrom Feb 5, 2026
Merged
Conversation
Icons were sometimes appearing as gray squares because their textures were used before the images had finished loading asynchronously. This fix restructures the icon texture loading to create materials without opacityMap initially, load textures asynchronously, and check material.opacityMap before rendering icons. Fixed #1703
willeastcott
added
bug
mvaligursky
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition where entity icons would occasionally appear as gray squares in the viewport. The issue occurred when materials were created with textures that hadn't finished loading yet.
Changes:
- Restructured texture loading to be fully asynchronous, creating materials without textures initially
- Added guard logic to prevent rendering icons until their textures are fully loaded
- Converted material storage from plain objects to Maps for better type safety
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixed #1703