Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Version Control picker UI from legacy Editor UI components to PCUI components, updating both TypeScript and Sass to match the new DOM/class structure.
Changes:
- Replaced several legacy UI components in the version control picker with PCUI equivalents (Container, Button, TextInput, SelectInput, Menu/MenuItem).
- Updated picker behavior to use PCUI menu show/hide events and icon-based buttons.
- Adjusted Sass selectors/styles to target PCUI classnames and layout structure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/editor/pickers/version-control/picker-version-control.ts | Migrates picker UI elements to PCUI and updates context-menu behavior accordingly. |
| sass/editor/_editor-main.scss | Updates editor-wide styling for the version control picker to align with PCUI containers/components. |
| sass/common/_version-control.scss | Updates version control-specific styles for PCUI menus/text inputs and branch list item interactions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1376
Migrate version control picker from legacy UI to PCUI
Migrates the top-level UI components in the version control picker (
picker-version-control.ts) from the legacy UI system to PCUI, along with corresponding CSS selector updates.Component migrations:
LegacyPanel→ PCUIContainerfor the main picker, branches container, branches filter, branches panel, right side panel, and branch list item containerLegacyTextField→ PCUITextInputfor the search inputLegacySelectField→ PCUISelectInputfor the branches filter dropdownLegacyMenu/LegacyMenuItem→ PCUIMenu/MenuItemfor the branches context menuLegacyButton→ PCUIButtonfor the load more button and branch dropdown buttonsLegacyLabel→ PCUILabelfor branch icon, name, and ID labelsCSS updates (
_editor-main.scss):.ui-panel.picker-version-controlto.pcui-container.picker-version-control.contentselectors since PCUI Containers don't use a.contentwrapper.ui-button→.pcui-button,.ui-label→.pcui-label,.ui-select-field→.pcui-select-input, etc.)CSS updates (
_version-control.scss):.ui-menuto.pcui-menuwith adjusted menu item height and label spacing.ui-text-fieldto.pcui-text-input.contentdivuser-select: textfor selectable branch labelsCode quality:
Changed
vartoconstfor 6 function-scoped variablesRemoved commented-out dead code
Removed duplicate comments
Fixed extra whitespace
Consolidated PCUI component properties into constructor calls
I confirm I have read the contributing guidelines