refactor: migrate project management pickers from legacy UI to PCUI#1928
Merged
willeastcott merged 3 commits intomainfrom Mar 10, 2026
Merged
refactor: migrate project management pickers from legacy UI to PCUI#1928willeastcott merged 3 commits intomainfrom
willeastcott merged 3 commits intomainfrom
Conversation
Replace LegacyOverlay and LegacyMenu usage in project management pickers with PCUI Overlay and Menu components. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the project management picker modals to consistently use PCUI components instead of the legacy UI layer, aligning these pickers with the rest of the editor’s modern PCUI-based UI.
Changes:
- Migrate multiple project-management modals from
LegacyOverlayto PCUIOverlay. - Replace the CMS organization dropdown from
LegacyMenuto PCUIMenu, updating open/close behavior to PCUI’shidden+hideevent pattern. - Update SCSS selectors to target PCUI class names and adjust menu hover styling to match PCUI DOM structure.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/editor/pickers/project-management/picker-modal-visibility-confirmation.ts | Switch visibility confirmation modal from LegacyOverlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-new-project.ts | Switch new project modal overlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-new-project-confirmation.ts | Switch new project confirmation modal overlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-new-organization.ts | Switch new organization modal overlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-delete-self-confirmation.ts | Switch delete-self confirmation modal overlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-delete-project-confirmation.ts | Switch delete-project confirmation modal overlay to PCUI Overlay. |
| src/editor/pickers/project-management/picker-modal-delete-organization.ts | Switch delete-organization modal overlay to PCUI Overlay; remove invalid renderChanges from delete button config. |
| src/editor/pickers/project-management/picker-cms.ts | Replace legacy org dropdown menu/overlay with PCUI Menu/Overlay and update visibility handling. |
| sass/editor/_editor-main.scss | Update selectors from legacy .ui-* to PCUI .pcui-* and refine menu item hover styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
PCUI Overlay centers content via flexbox, so the manual position/left/top/transform centering hacks are no longer needed. Made-with: Cursor
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1376
Summary
LegacyOverlaywith PCUIOverlayacross all project management picker modals (visibility confirmation, delete self confirmation, new organization, new project confirmation, new project, delete project confirmation, delete organization, CMS)LegacyMenuwith PCUIMenufor the organization dropdown inpicker-cms.ts.ui-overlay,> .content,.ui-menu) to PCUI equivalents (.pcui-overlay,> .pcui-overlay-content,.pcui-menu).pcui-menu-item-contentinstead of the root element.pcui-menu-item-childrencontainer from showing on hover for leaf menu itemsrenderChangesproperty fromButtonconstructor in delete organization modalTest plan