Skip to content

fix: remove index signature from ProjectSettings config type#1932

Merged
kpal81xd merged 1 commit intomainfrom
fix/remove-settings-index-signature
Mar 11, 2026
Merged

fix: remove index signature from ProjectSettings config type#1932
kpal81xd merged 1 commit intomainfrom
fix/remove-settings-index-signature

Conversation

@kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 11, 2026

Summary

  • Remove [key: string]: unknown from ProjectSettings type
  • Class instances don't satisfy index signatures, preventing assignability from concrete class implementations

Test plan

  • npm run type:check passes

Class instances don't satisfy index signatures, preventing the server's
ProjectSettings model from being assignable to this type.
@kpal81xd kpal81xd self-assigned this Mar 11, 2026
@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
editor Ready Ready Preview, Comment Mar 11, 2026 3:22pm

Request Review

@kpal81xd kpal81xd added the docs Improvements or additions to documentation label Mar 11, 2026
@kpal81xd kpal81xd merged commit fdbf1e2 into main Mar 11, 2026
7 checks passed
@kpal81xd kpal81xd deleted the fix/remove-settings-index-signature branch March 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant