Skip to content

fix: add index signature to ModelSchema for dynamic asset data schemas#1933

Merged
kpal81xd merged 1 commit intomainfrom
fix/schema
Mar 12, 2026
Merged

fix: add index signature to ModelSchema for dynamic asset data schemas#1933
kpal81xd merged 1 commit intomainfrom
fix/schema

Conversation

@kpal81xd
Copy link
Contributor

Summary

  • Adds [key: string]: object index signature to ModelSchema type
  • Allows dynamic asset data schema keys (materialData, textureData, animstategraphData, etc.) to pass type checking
  • Companion to playcanvas-monorepo fix that restores full schema injection in editor-server

Test plan

  • Run npm run type:check — no new errors
  • Select any asset in the editor — inspector loads without errors

@vercel
Copy link

vercel bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
editor Ready Ready Preview, Comment Mar 12, 2026 10:45am

Request Review

@kpal81xd kpal81xd self-assigned this Mar 12, 2026
@kpal81xd kpal81xd added the bug Something isn't working label Mar 12, 2026
@kpal81xd kpal81xd merged commit 7ced55b into main Mar 12, 2026
7 checks passed
@kpal81xd kpal81xd deleted the fix/schema branch March 12, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant