[Fix] Prevent OT op-too-long desync in code editor#1966
Merged
Conversation
Guard against offset exceeding document length, resync monaco after rollback+fetch, clear stale undo/redo on disconnect, and reset document errors on reconnect so the editor exits read-only mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove the realtime:disconnected handler that blanket-cleared all
undo/redo stacks. Clean reconnects already OT-transform stacks via
onInsert/onRemove, and rollback reconnects already clear stacks in
doc.on('load'). Also batch documents:error:cleared emit on reconnect.
…socket detection Restore asset error guard when connected, remove keep-alive pause/resume, and inline keep-alive setup back into _onauth. Keeps zombie socket detection on visibility change and event name fix from #1965.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
applyToShareDbagainst offset exceeding document length, emitting an error instead of sending an invalid opdoc.on('load')realtime:authenticated) so the editor exits read-only modedocuments:error:clearedindocument.tsto refresh readonly stateChecks