Skip to content

fix: prevent builds dialog from closing when using dropdown menu#1970

Merged
willeastcott merged 1 commit intomainfrom
fix/builds-dialog-dropdown-close
Mar 20, 2026
Merged

fix: prevent builds dialog from closing when using dropdown menu#1970
willeastcott merged 1 commit intomainfrom
fix/builds-dialog-dropdown-close

Conversation

@willeastcott
Copy link
Contributor

Summary

  • Migrated the builds dropdown from LegacyMenu to PCUI Menu, so the project overlay's existing .pcui-menu pointerdown guard recognizes it and no longer dismisses the builds dialog when the dropdown is open
  • Added a guard in the project overlay to prevent it from closing when clicking on a different overlay (e.g. the delete confirmation dialog)
  • Added CSS to hide the empty submenu children container on hover for leaf menu items in both the builds and scene dropdown menus

Fixes #1969

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
editor Ready Ready Preview, Comment Mar 20, 2026 3:18pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a UI regression where interacting with the builds dropdown / delete confirmation could unintentionally dismiss the “Project” builds dialog, by aligning the builds dropdown with existing PCUI overlay/menu click-guard behavior and tightening overlay dismissal rules.

Changes:

  • Migrates the builds “…” dropdown from LegacyMenu to PCUI Menu so it is recognized by the existing .pcui-menu pointerdown guard.
  • Updates the project overlay pointerdown handling to avoid closing when the user clicks inside a different overlay (e.g. confirmation modal).
  • Adds SCSS rules to hide the empty submenu children container on hover for leaf menu items in the builds and scene dropdown menus.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/editor/pickers/picker-project.ts Prevents the project overlay from closing when pointer events originate from a different .pcui-overlay.
src/editor/pickers/picker-builds-publish.ts Replaces LegacyMenu with PCUI Menu for the builds dropdown, using hidden/show/hide semantics consistent with other PCUI menus.
sass/editor/_editor-main.scss Adds menu styling to hide empty submenu containers for leaf items in builds/scene menus.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@willeastcott willeastcott merged commit 43257d3 into main Mar 20, 2026
12 checks passed
@willeastcott willeastcott deleted the fix/builds-dialog-dropdown-close branch March 20, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builds window close after deletion modal window appears

2 participants