fix: clean up camera-preview types and deprecations#1996
Merged
willeastcott merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
Remove non-existent FogType import, type app variable, use top-level import for EntityObserver, replace deprecated .element with .dom, convert function expressions to arrow functions, and remove redundant null checks. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up typings and deprecated API usage in the viewport camera preview feature, aligning the implementation with current PlayCanvas/PCUI types and patterns.
Changes:
- Removes invalid
FogTypeimport/cast and refines local typing (e.g.,app). - Updates PCUI usage from deprecated
.elementto.dom. - Refactors some callbacks to arrow functions and simplifies redundant null checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FogTypeimport fromplaycanvasand replace cast withstringappvariable asApplication | nullinstead of inferrednullimport type { EntityObserver }instead of inlineimport()syntax.elementaccessor with.domfunctionexpressions to arrow functions for consistencylastCamera &&null checks already guarded by outerif (lastCamera)Test plan